Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t create empty documents surge xt #732

Closed
baconpaul opened this issue Dec 12, 2022 · 1 comment · Fixed by #739
Closed

Don’t create empty documents surge xt #732

baconpaul opened this issue Dec 12, 2022 · 1 comment · Fixed by #739
Labels
Infrastructure
Milestone
XT 2.1

Comments

@baconpaul
Copy link
Contributor

Storage makes sure the user dir is there which is right for the vst. For rack we should use it if it is there of course but not create it.
@baconpaul baconpaul added this to the XT 2.1 milestone Dec 12, 2022
@baconpaul
Copy link
Contributor Author

basically add an argument to the SurgeStorage constructor which defaults to true to create the path if needed I guess. Then test with it absent to make sure we don't throw a fs::exception.

baconpaul added a commit to baconpaul/surge-rack that referenced this issue Dec 13, 2022
@baconpaul
Extra Content optional; Don't make Surge Docs Dir if not needed
42ac04a 
1. Update SurgeStorage to have a config object as an argument.
2. Make it so that we don't create the Surge XT user dir unless
   you reveal it. Closes surge-synthesizer#732
3. Scan the extra content path for wavetables; implement download;
   implement download ui; remove 3rd party wt from vcvplugin.
   Closes surge-synthesizer#710
@baconpaul baconpaul mentioned this issue Dec 13, 2022
Merged
baconpaul added a commit that referenced this issue Dec 13, 2022
@baconpaul
Extra Content optional; Don't make Surge Docs Dir if not needed (#739)
00082de 
1. Update SurgeStorage to have a config object as an argument.
2. Make it so that we don't create the Surge XT user dir unless
   you reveal it. Closes #732
3. Scan the extra content path for wavetables; implement download;
   implement download ui; remove 3rd party wt from vcvplugin.
   Closes #710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure
Projects
None yet
Milestone
XT 2.1
Development

Successfully merging a pull request may close this issue.

Extra Content optional; Don't make Surge Docs Dir if not needed baconpaul/surge-rack
1 participant
@baconpaul