Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Disabled prometheus/push so this crate don't need native-tls #5

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

sgirones
Copy link

@sgirones sgirones commented Aug 1, 2023

The push feature for the prometheus crate depends on reqwest, which depends on native-tls by default.

Since we are not using the prometheus/push feature for now, let's disable it and come back to it once the funcionality becomes necessary.

This is necessary for surrealdb to not depend on native-tls and rely on rustls completely

@tobiemh
Copy link
Member

tobiemh commented Aug 1, 2023

@sgirones is this what was causing the nightly build failures?

@sgirones sgirones changed the base branch from master to 0.2-surreal.x August 1, 2023 18:50
@sgirones
Copy link
Author

sgirones commented Aug 1, 2023

In part, yes: when we switched to ubuntu-latest, the cargo build was unable to find the openssl-dev dependency. We could try to install the necessary ubuntu package, but given we want to get rid of native-tls, let's try to accomplish it.

The nice side effect is that we may be able to get rid of the windows' dependencies installation too.

@sgirones sgirones merged commit 0af5d64 into 0.2-surreal.x Aug 1, 2023
3 checks passed
@sgirones sgirones deleted the no-native-tls branch August 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants