Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: keepIncorrectValues is ignored when choices are copied from another question #6490

Closed
masciugo opened this issue Jul 7, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@masciugo
Copy link
Contributor

masciugo commented Jul 7, 2023

Are you requesting a feature, reporting a bug or asking a question?

question/bug

What is the current behavior?

In my use case I have a dropdown question with choicesFromQuestion enabled and "keepIncorrectValues": true. The problem is that the incorrect value is not kept because the following method

https://github.com/surveyjs/survey-library/blob/master/src/question_baseselect.ts#L1334C1-L1344

use clearIncorrectValuesCore() instead of clearIncorrectValues()

is this intended? I would expect to keep the value

thank you

@andrewtelnov andrewtelnov self-assigned this Jul 10, 2023
@andrewtelnov
Copy link
Member

@masciugo It is fixed by commit above. I hope PR will be merged shortly.

Thank you,
Andrew

dmitry-kurmanov added a commit that referenced this issue Jul 10, 2023
…correct-values

honour keepIncorrectValues for choicesFromQuestion dropdown fix #6490
@OlgaLarina OlgaLarina added this to the v1.9.97 milestone Jul 10, 2023
@RomanTsukanov RomanTsukanov changed the title honour keepIncorrectValues for choicesFromQuestion dropdown Ddropdown: keepIncorrectValues is ignored when choices are copied from another question Jul 11, 2023
@RomanTsukanov RomanTsukanov changed the title Ddropdown: keepIncorrectValues is ignored when choices are copied from another question Dropdown: keepIncorrectValues is ignored when choices are copied from another question Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants