Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests related to Signaturepad failing #7174

Closed
Ahmad-anility opened this issue Oct 18, 2023 · 3 comments · Fixed by #7247
Closed

Unit tests related to Signaturepad failing #7174

Ahmad-anility opened this issue Oct 18, 2023 · 3 comments · Fixed by #7247
Assignees
Labels
bug user issue An issue or bug reported by users
Milestone

Comments

@Ahmad-anility
Copy link

Ahmad-anility commented Oct 18, 2023

Are you requesting a feature, reporting a bug or asking a question?

Reporting failing unit test

What is the current behavior?

Currently when I run unit test 2 unit test fails. Both of them are related to signaturepad.

Chrome Headless 118.0.5993.70 (Mac OS 10.15.7) question signaturepad Check signaturepad signauteWidth/Height properties FAILED
.
.
Chrome Headless 118.0.5993.70 (Mac OS 10.15.7) question signaturepad Check signaturepad signauteWidth/Height properties FAILED

.
.
Chrome Headless 118.0.5993.70 (Mac OS 10.15.7): Executed 2672 of 2673 (2 FAILED) 

tested on master branch current commit is 51bade9243e44c1741b274e97408381195155d16

@andrewtelnov andrewtelnov added bug and removed bug labels Oct 18, 2023
@andrewtelnov
Copy link
Member

@Ahmad-anility We run then on Ubuntu. Probably there is a difference. Could you check your signuturepad version?
Here is the link on our CI. It is green.

Thank you,
Andrew

@Ahmad-anility
Copy link
Author

@andrewtelnov , the version in the package.json is ^4.1.5 . But the latest is 4.1.6 therefore in my package-lock it is 4.1.6 I even tried the exact version 4.1.5 and it is still the same.

Cheers

@tsv2013
Copy link
Member

tsv2013 commented Oct 21, 2023

I have similar issue on macOS. We can add the cast in our code.

@JaneSjs JaneSjs added bug user issue An issue or bug reported by users labels Oct 23, 2023
andrewtelnov added a commit that referenced this issue Oct 28, 2023
Fixed #7174 - Unit tests related to Signaturepad failing
@OlgaLarina OlgaLarina added this to the v1.9.115 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user issue An issue or bug reported by users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants