Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Add Karabiner Elements link #8

Closed
wants to merge 1 commit into from

Conversation

perlun
Copy link

@perlun perlun commented Oct 24, 2018

Seil doesn't work since quite a long time ago (Sierra, High Sierra and now Mojave), so it makes sense to update the links.

Seil doesn't work since quite a long time ago (Sierra, High Sierra and now Mojave), so it makes sense to update the links.
@susam
Copy link
Owner

susam commented Mar 23, 2019

Thanks for the pull request. However, I am afraid I am not going to merge this. The documentation is already pretty clear that Seil was applicable for OS X, i.e., until OS X 10.11 El Capitan.

For macOS 10.12 Sierra and later versions, the documentation suggests using a builtin feature of macOS available at Apple menu > System Preferences > Keyboard > Modifier Keys. Therefore I do not see the need for the change in this pull request.

@susam susam closed this Mar 23, 2019
@perlun
Copy link
Author

perlun commented Mar 26, 2019

Hi @susam

Thanks for the pull request. However, I am afraid I am not going to merge this. The documentation is already pretty clear that Seil was applicable for OS X, i.e., until OS X 10.11 El Capitan.

Sure, do whatever you like. I just personally think it's a bad idea to link people to a dead project. The Seil project web page states that on its front page that:

This application is for older macOS.
Please use Karabiner-Elements since macOS Sierra.

If you don't like the way my PR was phrased, feel free to improve on it, e.g. state that "For older macOS versions, use Seil". The way it's phrased right now doesn't make it overly clear that this part of the README.md applies only to those versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants