Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VR - Getting version string with 21.33FF may be supported by other DOS kernels #1

Open
ecm-pushbx opened this issue Jun 22, 2024 · 3 comments
Open

VR - Getting version string with 21.33FF may be supported by other DOS kernels #1

ecm-pushbx opened this issue Jun 22, 2024 · 3 comments
Assignees
@susi
Labels
enhancement New feature or request external command Commands which are stand-alone programs
Milestone
0.8.5b

Comments

@ecm-pushbx
Copy link

Your current check for int 21h function 33FFh involves matching the OEM ID to 0FDh (plus some serial ID check):

dog/dog/src/ext/vr.c

Line 197 in 88646f1

else if (DOS_OEM == 0xFD) { /* FreeDOS */

However, other kernels like RxDOS and Enhanced DR-DOS now also may support this function. In order to check for its presence I have changed eg callver to preset dx as zero and then check for a nonzero return: https://hg.pushbx.org/ecm/callver/file/89f20e312a8e/callver.asm#l182

I think this is a solid way to support this function for any DOS version.
@susi
Copy link
Owner

susi commented Jun 23, 2024

Oh thanks for sharing! I had no idea any other DOS did this. Definitely going to look into this

@susi susi self-assigned this Jun 23, 2024
@susi susi added the enhancement New feature or request label Jun 23, 2024
@susi susi added this to the 0.8.5b milestone Jun 23, 2024
@ecm-pushbx
Copy link
Author

I added this function to my MS-DOS v4 fork as well.

@ecm-pushbx ecm-pushbx mentioned this issue Aug 7, 2024
Closed
@susi susi added the external command Commands which are stand-alone programs label Oct 3, 2024
@susi susi changed the title Getting version string with 21.33FF may be supported by other DOS kernels VR - Getting version string with 21.33FF may be supported by other DOS kernels Oct 3, 2024
susi added a commit that referenced this issue Oct 9, 2024
@susi
More accurate version information.
0abb7a1 
Always try to get true version (int21h/ax=3306h) as well as the kernel
string (int21h/ax=33ffh), and display these when successful.

Also fixes #1.

Tested with FreeDOS 1.3, SvarDOS 20240915, MS-DOS 3.31, 6.22 and
DR-DOS 3.41, 5.0, 6.0, 7.03
susi added a commit that referenced this issue Oct 9, 2024
@susi
More accurate version information.
afa47d3 
Always try to get true version (int21h/ax=3306h) as well as the kernel
string (int21h/ax=33ffh), and display these when successful.

This fixes #1 and #2.

Tested with FreeDOS 1.3, SvarDOS 20240915, MS-DOS 3.31, 6.22 and
DR-DOS 3.41, 5.0, 6.0, 7.03
susi added a commit that referenced this issue Oct 9, 2024
@susi
More accurate version information.
8b634cb 
Always try to get true version (int21h/ax=3306h) as well as the kernel
string (int21h/ax=33ffh), and display these when successful.

This fixes #1 and #3.

Tested with FreeDOS 1.3, SvarDOS 20240915, MS-DOS 3.31, 6.22 and
DR-DOS 3.41, 5.0, 6.0, 7.03
@susi
Copy link
Owner

susi commented Oct 9, 2024

DOG running VR in SvarDOS:
edr-dos-dog-0 8 5b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susi susi

Labels
enhancement New feature or request external command Commands which are stand-alone programs
Projects
None yet
Milestone
0.8.5b
Development

No branches or pull requests
2 participants
@susi @ecm-pushbx