#638 reset out of date stocktake items #655
Conversation
Could "Correct" a finalised stocktake...
|
@andreievg this should be go for review |
| get isOutdated() { | ||
| if (this.batches.some(batch => batch.isSnapshotOutdated)) return true; | ||
| // Check all item batches (with stock) are included by finding matching id in | ||
| // the stocktakeBatches for this this stocktakeItem |
src/localization/modalStrings.js
Outdated
| @@ -47,8 +47,9 @@ export const modalStrings = new LocalizedStrings({ | |||
| start_typing_to_select_supplier: 'Start typing to select supplier', | |||
| stock_quantity_greater_then_zero: 'Stock quantity must be greater then zero before finalising', | |||
| stocktake_no_counted_items: "Can't finalise a stocktake with no counted items", | |||
| stocktake_invalid_stock: 'In this stocktake:\n{0} item(s) counted will cause negative stock levels for for at least one batch\n{1} uncounted item(s) are out of date, to count them now will cause incorrect adjustments\n\nWould you like to reset counts and snapshots for these items?', | |||
| */ | ||
| reset(database) { | ||
| database.delete('StocktakeBatch', this.batches); | ||
| this.item.batches.forEach(itemBatch => { |
There was a problem hiding this comment.
this.item.batchesWithStock
There was a problem hiding this comment.
It looks a bit funky sometimes like this - if the SOH is 0 there will be no batches at all when the line is reset. Which is totally correct, just seems a little weird.
| onClose={this.closeModal} | ||
| title={this.getModalTitle()} | ||
| > | ||
| {this.renderModalContent()} | ||
| </PageContentModal> | ||
| <ConfirmModal |
There was a problem hiding this comment.
I might be missing a reason, but why is ConfirmModal not the same as others ? i.e. as content of PageContentModal ?
I would understand a requirement for a new Modal if ConfirmModal is not dismissible (i.e. either way the snapshot quantity is refreshed and a message showing that it's being done, maybe even with item names)
There was a problem hiding this comment.
The page content modal only covers the page, not the top nav bar - this means finalise was accessible.
There was a problem hiding this comment.
I omitted item names because there was already a lot of text in the modal. If the user is on to it they can sort by the Actual Quantity column to find the reset ones.
There was a problem hiding this comment.
A modal that stops finalisation due to negative quantity adjustment seems to fit the item names quite well. Plus the warning message here can be a lot shorter, something like I've mentioned in issue 638 -> Quantities for these items have changed while the stocktake is in progress (due to stock issued or received), both Counted Quantity and Snapshot quantity will be reset: {list items}
I don't think we should allow cancel button
There was a problem hiding this comment.
I'll have to get @alainsussol to re-translate 😝
Sounds good, I'll get that done... before lunch!?
|
Pr requests addressed @andreievg (though I dig if you're waiting on discussions at #638 ) |
Merge #653 first, this is branched off that. Or rebase this to that branch?