-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update the VERSION variable assignment method #1552
fix: update the VERSION variable assignment method #1552
Conversation
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This PR updates the Key Modifications:
Impact: These changes fix issue #1540 and improve VERSION handling without affecting the external interface or behavior of the code. The signatures of exported functions and global data structures remain unaltered. Observations: The changes are well-organized and address a specific issue. The use of |
@vprashar2929 , could you please explain why (instead of what) we are removing version? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make sure that this does not affect version
in the release workflow.
f1120ec
to
7983232
Compare
7983232
to
7abda07
Compare
07ce703
to
cfccdb6
Compare
Kepler using the latest image:
Kepler using the dummy release image:
|
This PR: * fixes the issue the VERSION variable assignment from `?=` to `:=` to ensure immediate evaluation of `$(GIT_VERSION)` * Use `fetch_depth` to fetch the tag info for computing the `GIT_VERSION` correctly while building Kepler images * Removes the `VERSION` argument from the Dockerfile * Removes the redundant bpftool COPY statement in build/Dockerfile * Addresses issue sustainable-computing-io#1540 Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
cfccdb6
to
c49a283
Compare
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Signed-off-by: Sunil Thaha <sthaha@redhat.com>
Removes the `VERSION` build-arg from the docker compose files as it was removed in sustainable-computing-io#1552 Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
Removes the `VERSION` build-arg from the docker compose files as it was removed in #1552 Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com>
Signed-off-by: Gabriela Dozortsev <gdozorts@redhat.com> Update pkg/collector/stats/utils.go Co-authored-by: Dave Tucker <dave@dtucker.co.uk> Signed-off-by: Gabriela Dozortsev <81634840+gdozortsev@users.noreply.github.com> Update pkg/collector/stats/utils.go Co-authored-by: Dave Tucker <dave@dtucker.co.uk> Signed-off-by: Gabriela Dozortsev <81634840+gdozortsev@users.noreply.github.com> Update pkg/collector/stats/utils.go Co-authored-by: Dave Tucker <dave@dtucker.co.uk> Signed-off-by: Gabriela Dozortsev <81634840+gdozortsev@users.noreply.github.com> fix: update the VERSION variable assignment method (sustainable-computing-io#1552) * fix: update the VERSION variable assignment method This PR: * fixes the issue the VERSION variable assignment from `?=` to `:=` to ensure immediate evaluation of `$(GIT_VERSION)` * Use `fetch_depth` to fetch the tag info for computing the `GIT_VERSION` correctly while building Kepler images * Removes the `VERSION` argument from the Dockerfile * Removes the redundant bpftool COPY statement in build/Dockerfile * Addresses issue sustainable-computing-io#1540 Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com> Signed-off-by: Sunil Thaha <sthaha@redhat.com> Co-authored-by: Sunil Thaha <sthaha@redhat.com> chore: remove version from docker-compose (sustainable-computing-io#1562) Removes the `VERSION` build-arg from the docker compose files as it was removed in sustainable-computing-io#1552 Signed-off-by: Vibhu Prashar <vibhu.sharma2929@gmail.com> Fixed format errors Signed-off-by: Gabriela Dozortsev <gdozorts@redhat.com>
This PR:
fixes the issue the VERSION variable assignment
from
?=
to:=
to ensure immediate evaluation of$(GIT_VERSION)
Use
fetch_depth
to fetch the tag info for computing theGIT_VERSION
correctly while building Kepler images
Removes the
VERSION
argument from the DockerfileRemoves the redundant bpftool COPY statement in build/Dockerfile
Addresses issue Version incorrectly reported in the container images #1540