Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Pingpong based heartbeat in Client based on the timeout. #12

Closed
wants to merge 2 commits into from
Closed

Pingpong based heartbeat in Client based on the timeout. #12

wants to merge 2 commits into from

Conversation

miwee
Copy link

@miwee miwee commented Aug 15, 2016

No description provided.

@suvash
Copy link
Owner

suvash commented Aug 22, 2016

Thanks for the PR.
This looks like a good start to the ping pong implementation. However, I'd like every change to the codebase well-tested. Please feel free to provide tests for the changes you've submitted as well, else give me some time(days/weeks) to think this through and have it wrapped with tests.

@suvash
Copy link
Owner

suvash commented Aug 10, 2017

@miwee Squashed the commits and used in #25, landed on master now.

@suvash suvash closed this Aug 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miwee @suvash