Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added method for autoscaling #304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sjbokhari
Copy link

Hey I added a method for autoscaling the pictures, since this is my first pull request Im not sure if everything is alright. Please let me know :)

@sjbokhari
Copy link
Author

@suyashkumar what do you say about this? :)

@suyashkumar
Copy link
Owner

@sjbokhari thank you for taking a stab at this! Unfortunately, if I understand correctly, correct autoscaling of a DICOM is a bit more complicated than picking the midpoint. I think we should be applying possible lookup table values, and/or trying to see if window center tags and others are present in the dicom to initialize the values. More details here: #2 (comment)

That said, maybe there's a way we can factor out some of this into a library or top level function in a pkg/ library that makes it clear it applies a different type of default scaling. e.g. MidpointScaling(NativeFrame frame) (image.Image, error).

WDYT? You're welcome to read more about dicom scaling at the issue above if you'd like to take a try at it! We can probably implement it incrementally or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants