Implement dicomio.Reader, add simple test program, fix some bugs #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashkumar
changed the title
suyashkumar
added a commit
that referenced
this pull request
Jul 19, 2020
…am, fix some bugs (#70) This change implements the initial dicomio.Reader, which unblocks the first end-to-end test of the rewritten prototype parser. A simple test program was added to test the library, which appears to successfully parse several simple test DICOMs! Several bugs were also caught and fixed. More robust e2e testing against a suite of public DICOMs should be added, in addition to more comprehensive unit testing as this rewritten library begins to take shape. Since this is on the rewrite branch, going to submit this to continue moving forward and building out a prototype rewrite.
suyashkumar
added a commit
that referenced
this pull request
Sep 17, 2020
…am, fix some bugs (#70) This change implements the initial dicomio.Reader, which unblocks the first end-to-end test of the rewritten prototype parser. A simple test program was added to test the library, which appears to successfully parse several simple test DICOMs! Several bugs were also caught and fixed. More robust e2e testing against a suite of public DICOMs should be added, in addition to more comprehensive unit testing as this rewritten library begins to take shape. Since this is on the rewrite branch, going to submit this to continue moving forward and building out a prototype rewrite.
suyashkumar
added a commit
that referenced
this pull request
Nov 2, 2020
…am, fix some bugs (#70) This change implements the initial dicomio.Reader, which unblocks the first end-to-end test of the rewritten prototype parser. A simple test program was added to test the library, which appears to successfully parse several simple test DICOMs! Several bugs were also caught and fixed. More robust e2e testing against a suite of public DICOMs should be added, in addition to more comprehensive unit testing as this rewritten library begins to take shape. Since this is on the rewrite branch, going to submit this to continue moving forward and building out a prototype rewrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the initial
dicomio.Reader, which unblocks the first end-to-end test of the rewritten prototype parser. A simple test program was added to test the library, which appears to successfully parse several simple test DICOMs!Several bugs were also caught and fixed.
More robust e2e testing against a suite of public DICOMs should be added, in addition to more comprehensive unit testing as this rewritten library begins to take shape.
Since this is on the rewrite branch, going to submit this to continue moving forward and building out a prototype rewrite.