Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala Native, update libraries, update scalafmt #247

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Jul 14, 2024

  • Update Scala 3 to 3.3.3
  • Update Scala 2.13 to 2.13.14
  • Update Scala 2.12 to 2.12.19
  • Update Scala.js to 1.16.0
  • Update Scala Native to 0.5.4
  • Update Scalafmt to 3.8.2
  • Update utest to 0.8.3
  • Update shapeless to 2.3.12

// dummy unsecure SecureRandom implementation for tests
// for real usage, use an implementation
// like https://github.com/lolgab/scala-native-crypto
class SecureRandom extends java.util.Random
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd, do we need to include a class in the java namespace?
Is this only needed for native?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's needed only on native, I need to move it to the right folder. I put it on shared by mistake.
I added it to not have to setup the openssl installation for tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it is needed also with Scala.js, so I added it to the js-native source directory.

Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.
I only checked the non formatting commit and in general it seems good
I had a question about the class in the java namespace

@cquiroz
Copy link
Contributor

cquiroz commented Jul 16, 2024

Thanks a lot. LGTM

@cquiroz cquiroz merged commit f6c7f86 into suzaku-io:master Jul 16, 2024
3 checks passed
@lolgab lolgab deleted the update-libs branch August 7, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants