-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scala Native, update libraries, update scalafmt #247
Conversation
// dummy unsecure SecureRandom implementation for tests | ||
// for real usage, use an implementation | ||
// like https://github.com/lolgab/scala-native-crypto | ||
class SecureRandom extends java.util.Random |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is odd, do we need to include a class in the java namespace?
Is this only needed for native?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's needed only on native, I need to move it to the right folder. I put it on shared
by mistake.
I added it to not have to setup the openssl installation for tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it is needed also with Scala.js, so I added it to the js-native
source directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
I only checked the non formatting commit and in general it seems good
I had a question about the class in the java namespace
Thanks a lot. LGTM |
3.3.3
2.13.14
2.12.19
1.16.0
0.5.4
3.8.2
0.8.3
2.3.12