refactoring v2 #10
Merged
refactoring v2 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVilgelm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the operations
The swagger v2.0 supports only a subset of the possible http methods and does not support any custom methods, like SEARCH and etc...
This change fixes the issue by getting rid of the predefined
get,postand other operations and using theBTreeMap<String, Operation>instead. So any operations can be used.The operation's name (method) is converted to lowercase in order to avoid duplications.
Reorganizing the validations
Move the helpers methods and the ValidateWithContext with Context to common::helpers mod.
So the libs::validation should have only Validate trait
Detect unused components
Refactor code to detect unused components, validate all components at the end and check if they were visited