Add new function for creation a connection DialKDBContext. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you base your change on v1beta? it changes Dial api, so i would prefer to make changes like this in that branch |
sv
reviewed
Aug 17, 2019
kdb.go
Outdated
| @@ -208,3 +209,37 @@ func DialKDBTimeout(host string, port int, auth string, timeout time.Duration) ( | |||
| kdbconn := KDBConn{c, bufio.NewReader(c), host, fmt.Sprint(port), auth} | |||
| return &kdbconn, nil | |||
| } | |||
|
|
|||
| // DialKDBContext connects to host:port using supplied user:password. It uses the context's build-in timeout. | |||
| func DialKDBContext(ctx context.Context, host string, port int, auth string) (*KDBConn, error) { | |||
There was a problem hiding this comment.
if based on v1beta, also rename to DialContext to follow net.Dialer interface
|
Tracking in #28 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue that when KDB went into debug trap mode it would allow establishing a TCP connection, but would not reply to handshake requests, causing the client to hang.
This new function allows to use a context specific timeout which forces a return even if the actual request hangs.
It will also close the connection, which should cause the handshake to fail so there will be no hanging go routine.
I thought about updating DialKDBTimeout with a similar functionality, but held off in case the existing behaviour was intentional. I can make the change if needed.