-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support core::fmt::Display
and alternative formats.
#2
Conversation
Hey, @reitermarkus! Thanks for a pull request :) Can we start with the master rebasing? Apparently, I broke the CI in here and it is fixed now in 16784c4 |
I checked the docs about the MAC addresses and have a proposal to change the formatting a bit. There are three possible ways to display the address:
We can make the colon notation to be the default formatting option, use I'm not sure about your default formatting |
I haven't seen it. I just thought having no separators by default and having to choose colons/hyphens explicitly would make sense. |
1bad124
to
d09da1e
Compare
I left the other formats as is and added |
Dot format is used for a numeric types and afaik can't be used without supplying the precision, so it is impossible to use it as a This does not seems to be very convinient and easy to remember; had you thought on my idea about formatting options? I would love to hear your thoughts on that. |
I changed it now to your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great! There is a small thing I would like to clarify, after that I'll be glad to merge and publish this PR :)
Awesome, everything looks great! I'm going to change some things in CI, check the results and will try to publish your change today |
No description provided.