-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deps #10
update deps #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, much appreciated! I have a couple of questions which I'll put below. Please don't worry if you don't know the answers, that's perfectly fine, we'll just have a chat about it and make a decision together.
- In the
Podfile
, you put only major versions on the dependencies. Normally I put also minor versions there, because I don't want Cocoapods to automatically upgrade major versions. After all, according to semantics versioning those are API breaking changes, and I don't want those to be applied automatically. The same applies to thepodspec
. - For
ReSwift
you left out the version dependency completely (inPodfile
); was that on purpose? - I noticed that Travis is failing. I didn't look into the reason yet. I suspect it doesn't have anything to do with your changes but the world simply changed too much since last time it ran. Still, if you feel like it, you're welcome to have a look and see if you can find the cause. If you'd rather not that's also fine, I'm not telling you to do it :)
Thanks for the comment. I believe we can also put minor versions. I just updated the podspec and podfile for my taste and ran tests and the example application for testing; both did not fail. Let me try if i can fix travis |
Ok then let's put in the minor versions. That will ensure that projects that depend on this can seamlessly upgrade through all newer minor versions, but explicit action (=verification) is needed on major version number increments. This is how semver was intended, even if it hardly works out in practice 😅 I really appreciate you looking into Travis, that's awesome (not my favourite thing to do 😬). |
@svdo Travis is happy now :) Thanks for this cool project |
Thanks for your praise! :) I really appreciate how you're making this very easy for me by fixing even Travis, awesome! |
No description provided.