Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated prettier version for template in package.json #10716

Closed
Myphz opened this issue Sep 12, 2023 · 0 comments · Fixed by #10410
Closed

Outdated prettier version for template in package.json #10716

Myphz opened this issue Sep 12, 2023 · 0 comments · Fixed by #10410
Labels
pkg:create-svelte

Comments

@Myphz
Copy link

Myphz commented Sep 12, 2023 •
edited
Loading

Describe the bug

The prettier version (and prettier-plugin-version) is outdated. There has been a new major release of both packages (3.0).
This is annoying, as other prettier plugins (e.g prettier-plugin-tailwindcss) require prettier version 3.0, and will generate warnings during installation with the current prettier version.

Reproduction

N/A, just create a project with the CLI with prettier included

Logs

No response

System Info

System:
    OS: Linux 6.4 Arch Linux
    CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400H @ 2.70GHz
    Memory: 10.06 GB / 15.42 GB
    Container: Yes
    Shell: 5.1.16 - /bin/bash
  Binaries:
    Node: 20.6.0 - /usr/bin/node
    npm: 10.0.0 - /usr/bin/npm

Severity

annoyance

Additional Information

I will soon open a PR for this issue.
@Myphz Myphz mentioned this issue Sep 12, 2023
Closed
5 tasks
@Myphz Myphz changed the title Bump prettier version for template in package.json Outdated prettier version for template in package.json Sep 12, 2023
@eltigerchino eltigerchino mentioned this issue Sep 26, 2023
Merged
dummdidumm pushed a commit that referenced this issue Nov 13, 2023
@benmccann @eltigerchino
feat: upgrade to prettier 3 and prettier-plugin-svelte 3 (#10410)
cbd60cc 
This will give users the new versions via create-svelte. The rest of the change is internal

closes #10751
closes #10716

---------

Co-authored-by: Tee Ming <chewteeming01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:create-svelte
Projects
None yet
Milestone
No milestone
2 participants
@dummdidumm @Myphz