Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types for goto are not correct #11397

Closed
paoloricciuti opened this issue Dec 19, 2023 · 1 comment · Fixed by #11398
Closed

Types for goto are not correct #11397

paoloricciuti opened this issue Dec 19, 2023 · 1 comment · Fixed by #11398

Comments

@paoloricciuti
Copy link
Member

Describe the bug

image
As you can see while opts.state is defined with a @param the actual type of the function uses an inline type so it's not being picked up by TS, this also causes svelte-check to fail

Reproduction

Logs

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.10.5 - /usr/local/bin/pnpm
  npmPackages:
    @sveltejs/adapter-auto: ^3.0.0 => 3.0.0 
    @sveltejs/kit: ^2.0.0 => 2.0.3 
    @sveltejs/vite-plugin-svelte: ^3.0.0 => 3.0.1 
    svelte: ^4.0.0 => 4.2.8 
    vite: ^5.0.0 => 5.0.10

Severity

blocking an upgrade

Additional Information

I've added blocking an upgrade because we use svelte-check on the CI, i assume this might be something generally used

@paoloricciuti
Copy link
Member Author

I'm gonna PR this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant