Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix description of generated file #10403

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

ivanhofer
Copy link
Contributor

I tried running the kit.svelte.dev project and immediately got greeted by an error message because type-info.js was not found.
It took some time to figure out how to generate it because the description was not up to date. This PR fixes it.

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

⚠️ No Changeset found

Latest commit: e5a92a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@geoffrich
Copy link
Member

Related: I tried to trigger the generation of this file automatically in #10301, but got blocked by CI issues and haven't had a chance to go back

@benmccann benmccann changed the title [chore] fix description of generated file docs: fix description of generated file Jul 18, 2023
@ivanhofer
Copy link
Contributor Author

Made a fix: now uses pnpm instead of npm

@PuruVJ
Copy link
Contributor

PuruVJ commented Jul 18, 2023

This should be run in dev command, like svelte.dev. could you add it there?

@ivanhofer
Copy link
Contributor Author

@PuruVJ done

Copy link
Contributor

@PuruVJ PuruVJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved, although that doesn't mean anything on this repo, someone with merging rights need to merge 😁

@benmccann benmccann merged commit b251b23 into sveltejs:master Jul 18, 2023
11 checks passed
@Conduitry
Copy link
Member

Conduitry commented Jul 25, 2023

FYI, this appears to have broken site deployments. We don't want to use pnpm update, because that doesn't just run the update script. It attempts to actually upgrade dependencies, which is wreaking all sorts of havoc. I've opened #10431 to use pnpm run update rather than pnpm update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants