Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: switch to dropcss in AMP example #10546

Merged
merged 10 commits into from
Aug 23, 2023
Merged

docs: switch to dropcss in AMP example #10546

merged 10 commits into from
Aug 23, 2023

Conversation

ghostdevv
Copy link
Member

Closes #10536

  • Switch to using dropcss
  • Add note about removing css in the docs
  • Add note in docs about adding <html amp> as we don't do that anywhere. I also want to discourage people from using ⚡ since dropcss doesn't support it - people definitely will be using it so I've added a safeguard (.replace('⚡', 'amp'))

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs Migrate off purify-css #10536
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 50f46cc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ghostdevv ghostdevv mentioned this pull request Aug 12, 2023
Closed
5 tasks
@ghostdevv ghostdevv mentioned this pull request Aug 12, 2023
Closed
@ghostdevv
Copy link
Member Author

ghostdevv commented Aug 12, 2023 •
edited
Loading

Don't merge until the site build is fixed 🙏 fixed, ty puru ❤️

@ghostdevv @PuruVJ
Update documentation/docs/40-best-practices/20-seo.md
0fd9493 
Co-authored-by: Puru Vijay <47742487+PuruVJ@users.noreply.github.com>
@benmccann benmccann changed the title [Amp] Switch to dropcss and update documentation docs: switch to dropcss in AMP example Aug 12, 2023
@benmccann
Copy link
Member

Thank you! I might wait a few days to review this to see if leeoniya/dropcss#64 gets accepted first

dummdidumm
dummdidumm approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Given it was one week and that dropcss doesn't seem very active currently I'm merging this now.

documentation/docs/40-best-practices/20-seo.md Outdated Show resolved Hide resolved
@dummdidumm dummdidumm merged commit d407c75 into sveltejs:master Aug 23, 2023
11 checks passed
@ghostdevv ghostdevv deleted the amp-purify-css branch August 23, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuruVJ PuruVJ PuruVJ left review comments

@dummdidumm dummdidumm dummdidumm approved these changes

@benmccann benmccann Awaiting requested review from benmccann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate off purify-css
4 participants
@ghostdevv @benmccann @dummdidumm @PuruVJ