-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump dts-buddy
and typescript
#11013
Conversation
🦋 Changeset detectedLatest commit: 74f99d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FWIW I also tried bumping typescript and dts-buddy recently 😬 It works and I don't think it breaks downstream, except that it allows us to use syntax that breaks downstream in the future. #10997 (comment) |
We don't use TypeScript syntax at all, so to me the risk seems low enough to not be worth worrying about |
the site build appears to be choking because it thinks this is JSX? i don't even know where to begin with this kit/packages/kit/src/exports/public.d.ts Line 744 in 2903eb9
|
There's lots of merge conflicts here, so I'll go ahead and close this and make the change in #11160 |
The combination of bumping
dts-buddy
and bumpingtypescript
seems to solve Rich-Harris/dts-buddy#34, which was worked around in c68d625. This means we can freely useimport('types')
in the codebase without it breaking declarations for users.I don't think bumping the
typescript
major should have any downstream impacts, but someone please sanity check me.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.