Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accept FormData as ReadOnlyFormData #1256

Merged
merged 2 commits into from
Apr 28, 2021
Merged

fix: accept FormData as ReadOnlyFormData #1256

merged 2 commits into from
Apr 28, 2021

Conversation

ignatiusmb
Copy link
Member

Closes #1215

This will enable users to pass in FormData in RequestHandler as RequestHandler<any, FormData>, while still restricting it to allow readable methods only.

image

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris Rich-Harris merged commit 354e384 into sveltejs:master Apr 28, 2021
@ignatiusmb ignatiusmb deleted the gh-1215 branch April 28, 2021 12:53
@george-lim george-lim mentioned this pull request Sep 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should ReadOnlyFormData type be exported?
3 participants
@ignatiusmb @dummdidumm @Rich-Harris