Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adapter-cloudflare-workers] add es2020 target to esbuild function to solve Unexpected character '#' error #1287

Merged
merged 2 commits into from
May 1, 2021

Conversation

jacob-8
Copy link
Contributor

@jacob-8 jacob-8 commented Apr 30, 2021

Fixes #1220 with the one-line fix proposed in issue: #1220 (comment) - this bug is a showstopper for using CI to publish as the manual edit workaround doesn't get committed.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Copy link
Member

thank you! mind adding a changeset so we can release this? just do pnpx changeset and follow the prompts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[adapter-cloudflare-workers] "Unexpected character '#'" error when running "wrangler publish"
3 participants