Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): export AdapterUtils type #1300

Merged
merged 2 commits into from
May 3, 2021
Merged

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented May 2, 2021

Before submitting the PR, please make sure you do the following

Export AdapterUtils from the root config type file for use in Adapters.

I am updating the Firebase adapter to the latest API and would like to utilise this AdapterUtils types internally.

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Copy link
Member

Thank you. Mind adding a changeset so we can release this?

@jthegedus
Copy link
Contributor Author

Never used pnpm changeset, hopefully I did that correctly.

@babichjacob
Copy link
Member

Never used pnpm changeset, hopefully I did that correctly.

I think you did it right! 🎉

@Rich-Harris Rich-Harris merged commit 16cca89 into sveltejs:master May 3, 2021
@jthegedus jthegedus deleted the patch-1 branch May 3, 2021 01:54
@jthegedus
Copy link
Contributor Author

Beautiful, thanks all! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants