Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove navigated to text from announcer #1305

Merged
merged 1 commit into from
May 2, 2021
Merged

remove navigated to text from announcer #1305

merged 1 commit into from
May 2, 2021

Conversation

Rich-Harris
Copy link
Member

we decided that the quickest way to fix #879 would be to remove the 'Navigated to' text from the announcer contents, so that it just announces the title. Later, when our i18n story is more fleshed out, we can use it to provide a way to customise this text.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@benmccann benmccann merged commit 5023e98 into master May 2, 2021
@benmccann benmccann deleted the announcer branch May 2, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make svelte-announcer text configurable
2 participants