Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getContext in favour of request.locals #1332

Merged
merged 6 commits into from
May 4, 2021
Merged

Conversation

Rich-Harris
Copy link
Member

Implements the first part of #984 (comment)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@Rich-Harris
Copy link
Member Author

This is another PR that will cause checks to fail until we release a new version — in this case because https://netlify.demo.svelte.dev/ won't build and deploy itself until @sveltejs/kit@next uses request.locals instead of request.context

@benmccann benmccann changed the title replace request.context with request.locals Remove getContext in favour of request.locals May 4, 2021
@Rich-Harris Rich-Harris merged commit 051c026 into master May 4, 2021
@Rich-Harris Rich-Harris deleted the request-locals branch May 4, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants