Fix navigation when base path is set and validate that option's value
#1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen #1608 ? This PR seems to be editing the same line of code. I'm wondering what you think about the difference between the two PRs |
|
I wasn't aware of that PR, it also seems to solve different, yet similar issues. Checking for a trailing slash would cover this issue and other cases, but I also think it's better to update the docs and mention it in the error message. |
…359/kit-paths-base
|
I've merged the other PR here, they should appear as a co-author. Also updated this PR's description. |
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
reviewed
Jun 11, 2021
benmccann
changed the title
base path is set and validate that option's value
|
updated some of the text slightly and merged. thank you! |
|
Thank you, Ben! That must've been a chore |
|
Nope. It was easy enough |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1359
Fixes #1476
Closes #1608
Updating the docs in this case would be better than manipulating the paths at runtime. Changing the regex or url slicing solves the problem for dev, but still throws when adapters starts building (I tried). Rather than adding checks for all possible uses at runtime or (worse) changing the config passed from the user, it would be clearer for the user to just make sure that the config is correct.