Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kit): correct engines constraint #1696

Merged
merged 3 commits into from
Jun 17, 2021
Merged

chore(kit): correct engines constraint #1696

merged 3 commits into from
Jun 17, 2021

Conversation

lukeed
Copy link
Member

@lukeed lukeed commented Jun 16, 2021

Maintain fix from #1470, but loosen other constraints which had no business being there.

Maintain fix from #1470, but loosen other constraints which had no business being there.
@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2021

🦋 Changeset detected

Latest commit: ec9b87e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

Hmm. I'm not sure about this. The motivation for that version number came from: #1000 (comment)

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's not really a reason anyone should be using Node 15 and I do think people have hit some issues with certain versions of it, but I guess I don't have an objection to this either

@lukeed
Copy link
Member Author

lukeed commented Jun 17, 2021

15 is irrelevant, shouldn't be used but will still work. This was mostly about lowering to the true values

@lukeed lukeed merged commit ea8cd54 into master Jun 17, 2021
@lukeed lukeed deleted the kit/engines branch June 17, 2021 15:27
@Conduitry
Copy link
Member

I believe 14.13.1 was used because it sounded like 14.13.0 had a bug that would cause problems for us.

It looks like the net result of this PR is just to allow 14.13.0 and to allow 15.x, and I doubt whether either of those are good things to be doing.

@dominikg
Copy link
Member

hmm, does this mean vite-plugin-svelte should also revise its constraints? given 15 is about to be EOL and 14.13.1 is a patch level i don't really see the value behind this and think the previous constraint was ok.

if 15 is allowed, should it be included in tests?

@benmccann
Copy link
Member

I don't think we should test against 15. I'm maybe okay saying we shouldn't prevent people from using it, but it definitely shouldn't be supported in any way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants