Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] ReadOnlyFormData types #1830

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

JeanJPNM
Copy link
Contributor

@JeanJPNM JeanJPNM commented Jul 5, 2021

Fixes types of the ReadOnlyFormData interface.
The changes allow instances of the class and its methods to be used inside a for ... of loop without receiving an error like:
TS2495: Type 'ReadOnlyFormData' is not an array type or a string type.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2021

🦋 Changeset detected

Latest commit: 8b061b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JeanJPNM JeanJPNM changed the title Fix readonly fomdata types Fix ReadOnlyFormData types Jul 5, 2021
@JeanJPNM JeanJPNM changed the title Fix ReadOnlyFormData types [fix] ReadOnlyFormData types Jul 5, 2021
Copy link
Contributor

@dreitzner dreitzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dummdidumm
Copy link
Member

Please add a changeset, then we'll merge

@dummdidumm dummdidumm merged commit 8affef2 into sveltejs:master Jul 6, 2021
@JeanJPNM JeanJPNM deleted the fix-readonly-fomdata-types branch July 6, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants