Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Change index.js exports to directory exports when packaging #1905

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

dummdidumm
Copy link
Member

Node encourages this via its resolution algorithm, and it makes for nicer imports
Closes #1891

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Node encourages this via its resolution algorithm, and it makes for nicer imports
Closes #1891
@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2021

🦋 Changeset detected

Latest commit: 749179c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm dummdidumm merged commit 277029d into master Jul 14, 2021
@dummdidumm dummdidumm deleted the package-dir-imports branch July 14, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add directory imports when generating packages
1 participant