Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check ports in a more cross-platform way. #2209

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

Karlinator
Copy link
Contributor

@Karlinator Karlinator commented Aug 14, 2021

related to #2020

We were using ports.blame() to check for port usage for the pretty error messages, but this silently fails on any system which does not have lsof. This PR instead uses ports.check(), which tries to listen to a port, as a more robust way to check if the port is in use. It still uses ports.blame() to find the process id using the port if possible.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2021

⚠️ No Changeset found

Latest commit: 1a56dba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/kit/src/cli.js Outdated Show resolved Hide resolved
packages/kit/src/cli.js Outdated Show resolved Hide resolved
@Rich-Harris Rich-Harris merged commit a24aba9 into sveltejs:master Aug 17, 2021
@Rich-Harris
Copy link
Member

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants