[chore] resolve outdated todos

[ignatiusmb]

Resolve some outdated TODOs that we can safely remove as we're approaching 1.0

[changeset-bot]

⚠️ No Changeset found

Latest commit: 602a1db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[benmccann]

nice cleanup!

[wallw-teal]

This broke some test mocks on our end. What's the best way to get import.meta.env to be defined in a non-vite context such as Jest or another test runner?

Edit: That's with a setup similar to this example except I think ours is using jest's esm support.

Overall not a huge deal, as there are multiple workarounds. Ideally there would be a project similar to vite-jest that would spin up Svelte Kit. I was just wondering if there was a recommended approach.

[benmccann]

there's an issue about this. it's been one of the things to figure out before 1.0: #1485

[patrickleet]

@wallw-bits @benmccann

I noticed this breaking tests for me as well - I think something like

import { browser } from './env.js'

const ssr = !browser

would do the trick, as then you can just mock $app/env.js with

jest.mock('$app/env.js', () => ({
  amp: false,
  browser: true, // or false for testing ssr
  dev: true,
  mode: 'test'
}))

[patrickleet]

just tried it - making that change locally did work

I think it also makes the code more DRY - import.meta.env.SSR is already being dealt with in env.

I'll make a PR.

[patrickleet]

PR made: #2353