Chore/update vite plugin svelte

[dominikg]

Before submitting the PR, please make sure you do the following

• It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
• This message body should clearly illustrate what problems it solves.
• Ideally, include a test that fails without this PR but passes with it.

Tests

• Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

• If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

with kit already updated to vite-2.5.3 , users can update to vite-plugin-svelte@1.0.0-next.20 on their own but this should increase adoption-rate and visibility for a feature that should solve a lot of pain people were having with transitive cjs dependencies.

Not sure if patch or minor 🤷‍♂️

[changeset-bot]

🦋 Changeset detected

Latest commit: f220efc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bluwy]

Should we remove the old auto-exclude code here too? (even though it should still work without). And we could also consider removing this faq section.

[dominikg]

yes, i think we should, good catch @bluwy . No point in sveltekit and vite-plugin-svelte doing the same thing.
Also updating the docs to mention the new automatic behavior is a good idea. Should be done on vite-plugin-svelte tho with a link from here.

[benmccann]

Agreed on removing the duplicate functionality from SvelteKit

I'd maybe just remove one sentence of the FAQ:

However, in the meantime, you can workaround this issue by adding the dependency to vite.optimizeDeps.include in svelte.config.js.

That should be done automatically now. The rest still seems relevant

[dominikg]

docs change in vite-plugin-svelte sveltejs/vite-plugin-svelte#158

[bluwy]

I'd maybe just remove one sentence of the FAQ:

@benmccann I think the first and second paragraph of that section can be removed though, as it should never happen anymore. The second paragraph also has a broken link. Removing those would also made the third paragraph redundant.

Perhaps we could replace with the ESM-only dep issue, or some other issues listed at #2086? as they would now be more common.

[benmccann]

The link in the second paragraph of the FAQ appears to be broken, so yeah we can remove the second paragraph. Perhaps we should add something at the very top of the SvelteKit FAQ that points at https://svelte.dev/faq and https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md

For the first perhaps we can rewrite it to something like:

SSR in Vite is not yet stable. Libraries work best with Vite when they distribute both CJS and ESM in their package and you may wish to work with library authors to make this happen.

[benmccann]

Oh crap. I thought I was being helpful and making some docs changes to this PR, but accidentally pushed them to master instead. @dominikg I just dropped your last commit from this PR to avoid the merge conflict and added a new commit to fix the lint error by formatting. I can merge this then if everything looks okay to you guys now

[dominikg]

maybe wait a little, @bluwy found an edge case where having packages without a valid export like @types/node as dependency of a svelte dep (eg routify) breaks vites optimizer. We're adding an option to exclude nefarious packages or honor existing excludes.

So there will be next.21 soonish

[dominikg]

next.21 is released