Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

live bindings for SSR code #245

Merged
merged 1 commit into from
Dec 9, 2020
Merged

live bindings for SSR code #245

merged 1 commit into from
Dec 9, 2020

Conversation

Rich-Harris
Copy link
Member

fixes #242

benmccann
benmccann approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. it seems a bit crazy to me that it's this much work to integrate with snowpack though. should some of this live there?

@Rich-Harris
Copy link
Member Author

Possibly. It's come up with conversations with @FredKSchott in the past, but I think we agreed that the implementation at the time was too immature to live in Snowpack

@Rich-Harris Rich-Harris merged commit fa7f2b2 into master Dec 9, 2020
@Rich-Harris Rich-Harris deleted the gh-242 branch December 9, 2020 00:48
@FredKSchott
Copy link
Contributor

Nice, I'll check this out before (or right after) we cut v3.0. I'm still planning for this (or something like it) to eventually live in Snowpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev module loader doesn't support live bindings
3 participants
@Rich-Harris @FredKSchott @benmccann