Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] externalize middlewares.js when not using entryPoint #2484

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

Conduitry
Copy link
Member

#2482 introduced a silly regression where normal builds not using entryPoint (where middlewares.js is (internally) imported from its normal location at .svelte-kit/node/middlewares.js) stopped having middlewares.js external. We need to check both possible paths.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 24, 2021

🦋 Changeset detected

Latest commit: 7a529d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry Conduitry changed the title External middlewares regression [fix] externalize middlewares.js when not using entryPoint Sep 24, 2021
@Conduitry Conduitry force-pushed the external-middlewares-regression branch from ab6017a to 7a529d0 Compare September 24, 2021 15:33
@Conduitry Conduitry merged commit 84e0dec into sveltejs:master Sep 24, 2021
@Conduitry Conduitry deleted the external-middlewares-regression branch September 24, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant