[fix] Invalidating a route now fires sveltekit:navigation-start event #2609
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2528
By now also calling
router.notify()
when invalidating an URL it is made sure that thesveltekit:navigation-start
event is fired upon invalidation.This way one can for example show a loading indicator when trying to reload the same page.
I am calling
router.notify()
instead of just dispatching thesveltekit:navigation-start
event to also updatenavigating
.Other than that it is just more consistent to have a
start
event when also having anend
event as one could expect both to be fired the same way they are when navigating normally.Before submitting the PR, please make sure you do the following
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0