Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] add types properly in exports in package.json #2896

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

dummdidumm
Copy link
Member

Fixes #2863
Also removes the somewhat weird types export "./types" which is redundant: you get these through the default import, too. This shouldn't be a breaking change either (at least right now), as only TypeScript would be able to deal with that import as it's type-only, and TypeScript isn't officially supporting the exports field yet. I don't know who would do import { SomeInterface } from '@sveltejs/kit/types'; anyway if you can do import { SomeInterface } from '@sveltejs/kit/types';.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #2863
Also removes somewhat weird types export "./types" which is redundant: you get these through the default import, too.
@Rich-Harris Rich-Harris merged commit e30d6b8 into master Nov 24, 2021
@Rich-Harris Rich-Harris deleted the fix-types-reference branch November 24, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/// <reference types="@sveltejs/kit" /> isn't work as intended.
2 participants