-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .gitignore files in create-svelte package to ignore all dotfiles with a prefix of .env #2905
Update .gitignore files in create-svelte package to ignore all dotfiles with a prefix of .env #2905
Conversation
…es with a prefix of .env
🦋 Changeset detectedLatest commit: 2d1d6a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
IMO this should only add |
Shouldn't only env files ending with .local be ignored by default? |
Thank you! Aside from the feedback above, can you reinstate the deleted checklist and add a changeset? |
…an all files beginning with .env
…mplate rather than all files beginning with .env
Thanks for the feedback, all! 🙌 @Conduitry - Sounds good. I updated the PR so that @bjon - Files like @Rich-Harris - Yes, checklist reinstated and changeset added. Please let me know if anything else is needed. 👍🏼 |
Fixes #2904.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0