Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change url protocol for prerender #3178

Merged
merged 1 commit into from
Jan 2, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 2, 2022

Fixes #3164

Fore prerenders, change fallback sveltekit protocol to http. (Thoughts?)

In Node and Safari, the sveltekit protocol is recognized and properly parsed. Firefox and Chrome however don't and incorrectly parses it. e.g. new URL('sveltekit://prerender/'), Firefox and Chrome reported //prerender/ as the pathname.

Looking at the spec (the scheme table), I think Node and Safari are correct, since presumably we're not using a domain or ipv4 address as the host.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2022

🦋 Changeset detected

Latest commit: e74b617

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 2, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: e74b617

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61d174e5ff2a6b00076858b3

@Rich-Harris
Copy link
Member

I think this is indicative of a deeper bug that resulted from #3126 — before, we'd pass a path (which is the same whether you're prerendering or not) but now we need a full URL for hydration. (The obvious thing to do would be to just use new URL(location), but that has edge cases of its own when you're using Kit to prerender snippets of HTML that are then embedded on a different path.)

This seems like a workable fix for now but we should probably think of something more comprehensive

@Rich-Harris Rich-Harris merged commit 784af5b into master Jan 2, 2022
@Rich-Harris Rich-Harris deleted the fix-url-pathname branch January 2, 2022 17:01
@github-actions github-actions bot mentioned this pull request Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$page.url.pathname represented as "//prerender/" when building using the static adapter
2 participants