fix: change url protocol for prerender #3178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3164
Fore prerenders, change fallback
sveltekit
protocol tohttp
. (Thoughts?)In Node and Safari, the
sveltekit
protocol is recognized and properly parsed. Firefox and Chrome however don't and incorrectly parses it. e.g.new URL('sveltekit://prerender/')
, Firefox and Chrome reported//prerender/
as thepathname
.Looking at the spec (the scheme table), I think Node and Safari are correct, since presumably we're not using a domain or ipv4 address as the host.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0