Prerender paths #322
Merged
Prerender paths #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again I find myself wishing we had some tests for
prerender, but without the time to make it so.If you have
config.paths.baseorconfig.paths.assets, those will be reflected in the prerendered HTML, which means the crawler gets confused and tries to visit non-existent (as far as the locally running app is concerned) paths. This PR fixes it by removingconfig.paths.assetsbefore testing to see if a file exists, and removingconfig.paths.basebefore crawling subsequent pages.