Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Adapter netlify: don't set the request body on get/head requests #3459

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

JeanJPNM
Copy link
Contributor

@JeanJPNM JeanJPNM commented Jan 20, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Fixes #3438 by checking the request method before setting the body of the request object.

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2022

🦋 Changeset detected

Latest commit: 6b779da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Jan 20, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: 6b779da

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/61e9a8ca7c77c200085f825e

@JeanJPNM JeanJPNM changed the title don't set the request body on get/head requests [fix] Adapter netlify: don't set the request body on get/head requests Jan 20, 2022
@Rich-Harris Rich-Harris merged commit 4d58e10 into sveltejs:master Jan 20, 2022
@Rich-Harris
Copy link
Member

thanks!

@JeanJPNM JeanJPNM deleted the adapter-netlify-req-body-issue branch January 20, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netlify: Request with GET/HEAD method cannot have body
2 participants