Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Netlify Edge Functions #4657

Merged
merged 10 commits into from
Apr 20, 2022

Conversation

ascorbic
Copy link
Contributor

This PR adds support for the beta release of Netlify Edge Functions to the Netlify adapter. It adds an option edge to the adapter, which if set to true, compiles an edge function that runs on the Deno runtime as well as an edge functions manifest, instead of the Node-based Netlify Function.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2022

🦋 Changeset detected

Latest commit: 88a12d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and congrats on the launch! I made a small tweak to the README (the GitHub UI didn't let me use the suggestion tool, since the diff had both red and green, but our convention is to document all the available options in the code sample), and added an inline comment about handling edge: true alongside split: true

packages/adapter-netlify/index.js Outdated Show resolved Hide resolved
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Matt Kane <m@mk.gg>
@Rich-Harris Rich-Harris merged commit 41db4a3 into sveltejs:master Apr 20, 2022
@Rich-Harris
Copy link
Member

thank you!

@Masstronaut
Copy link
Contributor

@ascorbic thrilled to see you implemented this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants