[fix] change Vite's output directory from _app to client #5620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that @userquin ran into trying to make
vite-plugin-pwa
work with SvelteKit. He was using Vite/Rollup'semit
to output a service worker manifest and expecting it to be served from the root directory, but it was ending up under_app
._app
is arguable only for stuff generated by SvelteKit though. I could imagine lots of other things like arobots.txt
or something you might want to generate with a Vite plugin that need to go in a certain location and are impossible to put there today.I also think the code ends up being a little nicer this was as we don't end up having to specify the app dir in quite as many places
I'm splitting this out from #5601 as that PR was becoming too unwieldy