Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return 404 instead of 200 for stale assets with adapter-cloudflare #6879

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

raduab
Copy link
Contributor

@raduab raduab commented Sep 19, 2022

Hello, this is my first PR, so please bear with me.

After experiencing numerous problems when deploying new code to Cloudflare Pages with stale assets and cache settings (e.g. when Argo or Early Hints services were enabled), I discovered that requesting a non-existent asset from the _app directory always returned a status code of 200 and the contents of the static 404.html file if it existed, or nothing at all if it didn't. This caused a lot of issues for our users because they had to hard refresh our web page after a new deployment in order to invalidate the wrong cached content in their clients due to some bizarre Cloudflare Edge issues—this was needed even after purging the Cloudflare's cache.

Instead of constructing a new response object and returning it as if the asset was there, I updated the Cloudflare adapter to return early if the asset was not found. I also included a check before caching the server response to avoid caching if the response was not ok.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: 6682e53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

thank you, and congrats on your first PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants