-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include ambient.d.ts files in adapter packages. #6917
Conversation
Fixes automatic typing for Cloudflare caches and similar stuff.
🦋 Changeset detectedLatest commit: dffdf12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you — we actually don't want the ambient.d.ts
files to be included with adapter-netlify
, adapter-node
and adapter-vercel
because they're purely concerned with the adapter innards. but we do want it in the case of adapter-cloudflare
and adapter-cloudflare-workers
. the distinction could probably be clearer but for now it's easier to just do this
Ah ok! Sorry, didn't realise that. Thanks for making the changes. |
Fixes automatic typing for Cloudflare caches and similar stuff.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0