Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vite 3.2 #7400

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Upgrade to Vite 3.2 #7400

merged 4 commits into from
Oct 28, 2022

Conversation

benmccann
Copy link
Member

I wasn't sure if I should include a changeset and didn't for now. This mostly affects tests. create-svelte does use a newer version, but you'd have already gotten the latest upon using npm install previously, so I'm not sure there's really a user-visible change here

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2022

⚠️ No Changeset found

Latest commit: d2e96d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Conduitry
Copy link
Member

Does 3.2 provide any new features we're going to want to make use of? Before we hit SvelteKit 1.0 is the time to be doing any bumping of peerdeps.

@benmccann
Copy link
Member Author

There's not much in 3.2 that affects us. Only thing I see in the changelog is vitejs/vite#9970, which is a bug fix for #1042

@dominikg
Copy link
Member

just triggered a rerun of tests on #7355 that should go in first otherwise it gets breaking changes from this here. ofc. we can also just redo it after, but would rather not

@benmccann
Copy link
Member Author

We can't merge this anyway. lint is failing because of vitejs/vite#10656

@benmccann benmccann marked this pull request as draft October 27, 2022 15:32
@dominikg
Copy link
Member

someone mentioned adding types/picomatch to devDependencies as a workaround. We can either do that or wait until fixed in vite. Also checking if we can enable out lint in ecosystem-ci to catch these earlier.

@dominikg
Copy link
Member

fix has already been merged in vite, so better to wait here and bump to 3.2.1

@Rich-Harris
Copy link
Member

i bumped esbuild across the board so that we don't end up with two versions in the lockfile

@benmccann
Copy link
Member Author

Sounds good

@Rich-Harris Rich-Harris merged commit 004e81b into sveltejs:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants