Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only apply polyfills where necessary #7668

Merged
merged 1 commit into from
Nov 15, 2022
Merged

only apply polyfills where necessary #7668

merged 1 commit into from
Nov 15, 2022

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Nov 15, 2022

ref #7374. i think we tried this once before but had to undo it because of problems with Node 18, but let's give it another go and see what happens with the tests

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2022

🦋 Changeset detected

Latest commit: b1e6461

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we originally added it here: 7ed3c95#diff-8cae4ccc562be888fea664ae92b47321887907a9d0839c25809da043d6359457

and then removed it here #5292 because of #5292 (comment)

since all the checks are passing I don't see a reason not to merge this

@Rich-Harris Rich-Harris merged commit e7e3816 into master Nov 15, 2022
@Rich-Harris Rich-Harris deleted the gh-7374 branch November 15, 2022 23:26
Rich-Harris added a commit that referenced this pull request Nov 16, 2022
Rich-Harris added a commit that referenced this pull request Nov 16, 2022
dummdidumm pushed a commit that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants