-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump typescript #7669
bump typescript #7669
Conversation
🦋 Changeset detectedLatest commit: d7c8a6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Couple of blockers:
|
I filed an issue in the sucrase repo: alangpierce/sucrase#763. It's now been addressed |
Re "use satisfies in the docs" - I would maybe wait 1-2 months before doing that, so people can familiarize themselves more with that. Also, VS Code is likely not on TS 4.9 yet so everyone not turning on "use TS workspace version" would see type errors and be confused. |
Another blocker: |
Aside: It would be great if this microsoft/TypeScript#51086 was implemented, too - then JSDoc could also use that, and we don't need to create proxy types anymore for both JS/TS when people use it. |
Bummer, |
Prettier was updated in the 2.8 release (prettier/prettier#13792), which
|
@@ -82,7 +82,11 @@ const redirects = { | |||
}; | |||
|
|||
/** @type {import('.').default} **/ | |||
export default function ({ external = [], edge, split } = {}) { | |||
export default function ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need to duplicate the types here. just declare the function as a const
and then export it later
|
#7654. We also need to
satisfies
(in this PR, or in a follow-up?)satisfies
in the templatePlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0