lateral motion #123
Merged
lateral motion #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PuruVJ
reviewed
Jun 9, 2023
| $current_menu_view = $page_selected; | ||
| }); | ||
|
|
||
| afterNavigate(({ to }) => { |
There was a problem hiding this comment.
This is much better! I keep forgetting Kit has these 😅
This was referenced Jun 12, 2023
PuruVJ
added a commit
that referenced
this pull request
Jun 12, 2023
* Push * Direclt render list data ratehr than component * Fix bugs * Imports * Add motion * Slightly smoother menu * Motion aware, remove motion toggle * Minor change * Add external-link icon * lateral motion (#123) * lateral motion * prevent flickering contextual nav * tidy some stuff up * reorder things * slide down feels more natural when navigating directly * fix links * use navigation lifecycle * remove unused action * gah typescript * Use fade out for exit * Original namr * Slightly slower menu close --------- Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Puru Vijay <devpuruvj@gmail.com> * Incorporate changes from #120 --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <git@rich-harris.dev>
PuruVJ
added a commit
that referenced
this pull request
Jun 12, 2023
* Push * New DocsMobileNav * Support 4.0.0 * Use JS + Accessibility * Nav title * Minor fixes * Redo many things, new docsmobile nav mechanics * Remove unused imports * Minor fixes here and there * Fix blockquotes * use $page.data.nav_title * SSR ready * Some restructuring * Bottom nav first concept(incomplete) * tweak svelte recent searches * Better tap highlight color * Tweak DocsMobileNav * Initially hidden nav functionality * Unified navbar * Simplify into one single nav * Trickify * Use quintOut for navbar autohide * Minor fixes * Minor tweaks * Nav stays under overlay when searching * Pad the button * color mixed sk-theme-1 * Add changeset * Update changeset * Change icons a bit * One menu to rule em all (#118) * Push * Direclt render list data ratehr than component * Fix bugs * Imports * Add motion * Slightly smoother menu * Motion aware, remove motion toggle * Minor change * Add external-link icon * lateral motion (#123) * lateral motion * prevent flickering contextual nav * tidy some stuff up * reorder things * slide down feels more natural when navigating directly * fix links * use navigation lifecycle * remove unused action * gah typescript * Use fade out for exit * Original namr * Slightly slower menu close --------- Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Puru Vijay <devpuruvj@gmail.com> * Incorporate changes from #120 --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <git@rich-harris.dev> --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <git@rich-harris.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures there's only one direction of movement at any given moment, by abusing
clip-pathand having a fake backgroundI probably made a bit of a mess while working on this, so I might tidy some stuff up before marking it ready