Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svelte.dev site #78

Merged
merged 79 commits into from
Dec 14, 2021
Merged

Add svelte.dev site #78

merged 79 commits into from
Dec 14, 2021

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Dec 3, 2021

The docs code formatting looks a bit funny. It matches kit.svelte.dev, but I think perhaps the svelte.dev version looks nicer

This does not migrate the homepage to use the new site-kit, but pulls in the old one via pnpm as site-kit-legacy for now

@Rich-Harris
Copy link
Member

We'll need to revisit all this once the docs action has been updated and sveltejs/api.svelte.dev#13 has been merged — right now there are some CORS errors and incorrect slugs.

In the meantime, I know it wasn't introduced by this PR but this looks super horsey, will take a look and see if we can't finesse it a bit.

image

Will take a look at the docs CSS too

@Rich-Harris Rich-Harris marked this pull request as ready for review December 14, 2021 21:48
@Rich-Harris Rich-Harris merged commit 257ac05 into master Dec 14, 2021
@Rich-Harris Rich-Harris deleted the svelte-dev branch December 14, 2021 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants